Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve entrypoint #45

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Improve entrypoint #45

merged 2 commits into from
Jan 9, 2025

Conversation

lreiher
Copy link
Member

@lreiher lreiher commented Dec 23, 2024

  • make chown in entrypoint safe from existing uid/gid
  • add warnings if uid/gid is already existing

@lreiher lreiher requested a review from jpbusch December 23, 2024 14:47
@lreiher
Copy link
Member Author

lreiher commented Dec 23, 2024

Transfer same changes to docker-ros-ml-images?

@jpbusch jpbusch mentioned this pull request Jan 9, 2025
Merged
@jpbusch
Copy link
Collaborator

jpbusch commented Jan 9, 2025

I have created the corresponding docker-ros-ml-images PR: ika-rwth-aachen/docker-ros-ml-images#17

@jpbusch jpbusch merged commit a954c02 into main Jan 9, 2025
6 checks passed
@jpbusch jpbusch deleted the entrypoint-improvements branch January 9, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbusch jpbusch jpbusch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lreiher @jpbusch